Skip to content

Conversation

@canac
Copy link
Contributor

@canac canac commented Jan 15, 2026

Description

Load the requests progressive approval tier to be able to show who will approve requests and how about how long it will take.

Depends on https://github.com/CruGlobal/mpdx_api/pull/3139

MPDX-9214

Caveats

  • I'm waiting on confirmation from Joanna about potentially hiding the additional info box when the user requires under Management Compensation Committee tier of approval. We will always show the additional info box

Testing

  • Case 1
    • Go to a salary request
    • Set one person's requested salary to just above their max
    • Check that step 3 says they need approval from the division head
  • Case 2
    • Go to a salary request
    • Set one person's requested salary to $500K
    • Check that step 3 says they need approval from the board compensation committee

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
  • I have run the Claude Code /pr-review command locally and fixed any relevant suggestions
  • I have requested a review from another person on the project
  • I have tested my changes in preview or in staging
  • I have cleaned up my commit history

@canac canac requested a review from wjames111 January 15, 2026 21:03
@canac canac self-assigned this Jan 15, 2026
@canac canac added Preview Environment Add this label to create an Amplify Preview Staging API Run GraphQL codegen against the staging API labels Jan 15, 2026
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

Bundle sizes [mpdx-react]

Compared against a191ce6

No significant changes found

Copy link
Contributor

@wjames111 wjames111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I couldn't find any issues.

@canac canac removed the Staging API Run GraphQL codegen against the staging API label Jan 16, 2026
@canac canac enabled auto-merge January 16, 2026 19:36
@canac canac merged commit 249d245 into main Jan 16, 2026
71 of 103 checks passed
@canac canac deleted the 9214-progressive-approval-tier branch January 16, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Preview Environment Add this label to create an Amplify Preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants