extra fields are exposed with a JSON description #241
Conversation
| try { | ||
| // Parsing description as a JSON | ||
| descObj = JSON.parse(descStr); | ||
| for (const x in descObj) { |
There was a problem hiding this comment.
What happens when the payload is json, but not structured as a dict?
There was a problem hiding this comment.
If the provided description is not structured as a JSON dictionary, it is not a JSON. Consequently, it would treat it as a plain text and it would not be processed thus entering the catch block.
| } | ||
| } catch(e) { | ||
| //Not a JSON description | ||
| metaDivp.text("{{.Description }}"); |
There was a problem hiding this comment.
Isn't {{.Description}} already emitted in the paragraph block above?
There was a problem hiding this comment.
The paragraph needs to reset its text before the try block. On the contrary, it would append the processed JSON description just after the unprocessed description. The catch is for the text that it is not structured as JSON.
|
There's no documentation of this new feature, so as it stands it will have just one user. |
We will update the readme.md explaining the additions. |
|
@pramsey We have updated the readme explaining the changes |
3 participants
This PR solves issue #236