-
Notifications
You must be signed in to change notification settings - Fork 552
update to VRFV2 #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
update to VRFV2 #681
Conversation
|
@pappas999 Thank you for taking the time to create this PR. I see that you updated all the |
|
thanks @andreipope , I updated the previous lessons as well. Everything should be consistent now |
TomiOhl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I have some thoughts on the styling, but nothing major.
|
thanks @TomiOhl , I incorporated the feedback given. Please take a look when you can, thanks! |
TomiOhl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Looks fine to me now. Except that I found this one more thing, let's fix up that one too and it'll be ready to go.
en/19/11.md
Outdated
| zombies.push(Zombie(_name, _dna)); | ||
| } | ||
| // Delete the function below |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be complete, a "1." should be added here
|
thanks @TomiOhl , i added the change, as well as a couple others I spotted on other pages while doing a check through again. |
TomiOhl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Didn't notice them since there wasn't even a blank space after the slashes.
From my side, I think it's ready to merge!
updated Chainlink VRF section to use the new Chainlink VRF V2