Skip to content

Fix typo, the first argument is passed by reference #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
piersy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typo, the first argument is passed by reference #741

piersy wants to merge 1 commit into from

Conversation

@piersy
Copy link

@piersy piersy commented Apr 15, 2023

This had me confused, as I understand it strings are always passed by reference.

  • I did these translations myself and own copyright for them
  • I didn't use a machine to do these translations
  • I assign all copyright to Loom Network for these translations

@piersy piersy changed the title Fix typo, the first argume is passed by reference Fix typo, the first argument is passed by reference Apr 15, 2023
keatumal
keatumal approved these changes Jan 9, 2025
View reviewed changes
Copy link

@keatumal keatumal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing, it's a simple typo, but I stuck with it for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@keatumal keatumal keatumal approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@piersy @keatumal