Merged
Conversation
Merged
hnaether-c8y
approved these changes
May 26, 2025
Collaborator
hnaether-c8y
left a comment
hnaether-c8y
left a comment
There was a problem hiding this comment.
Approved with one suggestion
| description: '', | ||
| component: OperationsWidgetComponent, | ||
| configComponent: OperationsWidgetConfigComponent, | ||
| previewImage: require('./assets/preview.png') as string, |
Collaborator
There was a problem hiding this comment.
You could switch and use the new assets.ts approach where you define images as imports in a ts file and then do an export const. That way you can then use it as a const value and dont need the require.
Contributor
Author
There was a problem hiding this comment.
i'll create a task to check other, already imported plugins to follow that approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/dirk-peter-c8y/cumulocity-widget-operations/tree/main