Skip to content

CI: Upgrade to VS2022, update actions#2470

Merged
LukeUsher merged 1 commit into
Cxbx-Reloaded:masterfrom
Margen67:ci
Jul 11, 2025
Merged

CI: Upgrade to VS2022, update actions#2470
LukeUsher merged 1 commit into
Cxbx-Reloaded:masterfrom
Margen67:ci

Conversation

@Margen67

Copy link
Copy Markdown
Member

VS2022 currently fails to build.

@github-actions github-actions Bot added the deployment CI and/or distribution issue label Dec 13, 2024
@Margen67 Margen67 marked this pull request as ready for review December 14, 2024 21:11
@RadWolfie

RadWolfie commented Dec 15, 2024

Copy link
Copy Markdown
Member

The reason of fallback to VS2019 is due to current VS2022 has defective compiler. Even if VS2022 has successfully compiled, we will receive false positive reports from our testers and users. For this reason, it is unlikely we will accept this pull request even if it's parallel builds.

If you separate the actions update changes into another pull request, I will be gladly accept them right away. Yet, I will verify to be sure all the other actions are up to date as well before approval.

@Margen67

Copy link
Copy Markdown
Member Author

The reason of fallback to VS2019 is due to current VS2022 has defective compiler. Even if VS2022 has successfully compiled, we will receive false positive reports from our testers and users. For this reason, it is unlikely we will accept this pull request even if it's parallel builds.

If you separate the actions update changes into another pull request, I will be gladly accept them right away. Yet, I will verify to be sure all the other actions are up to date as well before approval.

What's wrong with VS2022? If it gets false positives then that's a problem with the virus detection.

If you want I can make it so VS2022 builds are excluded from releases so users don't download them.

@RadWolfie

RadWolfie commented Dec 15, 2024

Copy link
Copy Markdown
Member

The problem isn't virus detection. It is that the whole builds from CI (VS2022) are defective (aka the msvc compiler issue). Some titles doesn't get past the loading screen or progress further. We are not using the latest VS2022 version because of this. Once confirmation from testers say the latest VS2022 build is back to working state for able to progress. Then we will replace it back with VS2022 in CI workflow.

Besides the above primary issue, the other side effects such as the "Config Input" window cause a crash and emulation crashes. The users need to re-update the Visual C++ Redist package. (Except we're not worry about this, and will require to advice users to do this action anyway.)

@Margen67 Margen67 mentioned this pull request Dec 16, 2024
@Margen67 Margen67 changed the title CI: Add back VS2022, update actions CI: Add back VS2022 Dec 17, 2024
@medievil1

medievil1 commented Jan 4, 2025

Copy link
Copy Markdown
Contributor

will VS2022 compile code as VS2019? asking cause VS2019 is no longer available to install
EDIT
Nevermind, I see the tools are still there...

@Margen67

Copy link
Copy Markdown
Member Author

VS2019 was removed from GitHub Actions: actions/runner-images#12045

@github-actions github-actions Bot added the modules submodules label Jul 11, 2025
@Margen67 Margen67 changed the title CI: Add back VS2022 CI: Upgrade to VS2022, update actions Jul 11, 2025
@LukeUsher LukeUsher merged commit d1bd03a into Cxbx-Reloaded:master Jul 11, 2025
3 of 5 checks passed
@Margen67 Margen67 deleted the ci branch July 11, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment CI and/or distribution issue modules submodules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants