Skip to content

add riscv rvv ci - #1049

Merged
Cyan4973 merged 4 commits into
Cyan4973:devfrom
zijianli1234:dev
Jul 19, 2025
Merged

add riscv rvv ci#1049
Cyan4973 merged 4 commits into
Cyan4973:devfrom
zijianli1234:dev

Conversation

@zijianli1234

@zijianli1234 zijianli1234 commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

This PR introduces CI testing for RISC-V RVV (Vector Extension) to validate the correctness of the RVV code across various vector lengths: vlen=128, 256, and 512.
Additionally, it addresses a bug related to "cast increases required alignment of target type".

@Cyan4973 Cyan4973 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed an important test to run in CI since RVV extension has been added to XXH3.

@zijianli1234

Copy link
Copy Markdown
Contributor Author

hi @Cyan4973, this PR has problems?

@camel-cdr

Copy link
Copy Markdown
Contributor

I recommend additionally setting the rvv_ta_all_1s=on,rvv_ma_all_1s=on flags, to make sure improper use of the agnostic policy produces errors, and if the qemu version available is new enough rvv_vl_half_avl=on to make sure the permitted vsetvl behavior for AVL<VLMAX*2 && AVL>VLMAX is tested properly.

@Cyan4973 Cyan4973 self-assigned this Jul 18, 2025
@zijianli1234

Copy link
Copy Markdown
Contributor Author

I recommend additionally setting the rvv_ta_all_1s=on,rvv_ma_all_1s=on flags, to make sure improper use of the agnostic policy produces errors, and if the qemu version available is new enough rvv_vl_half_avl=on to make sure the permitted vsetvl behavior for AVL<VLMAX*2 && AVL>VLMAX is tested properly.

Thanks for your suggestions. rvv_ta_all_1s=on,rvv_ma_all_1s=on has been added to the end of the QEMU launch parameters. However, the current QEMU version is 8.2.2, released in 2023, while rvv_vl_half_avl=on was introduced in August 2024, so it is not added for now.

@Cyan4973
Cyan4973 merged commit 55d9c43 into Cyan4973:dev Jul 19, 2025
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants