fix(wikipedia): handle HTTP errors in document comparison and log err… #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances error handling in the Wikipedia updater workflow by specifically catching and logging HTTP errors that occur during document comparison operations.
Changes:
- Added HTTP error handling to catch
requests.exceptions.HTTPErrorduring document comparison - Implemented database logging for HTTP errors via
ErrorRetrievalentries
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
welearn_datastack/nodes_workflow/WikipediaUpdater/wikipedia_updater.py
Outdated
Show resolved
Hide resolved
welearn_datastack/nodes_workflow/WikipediaUpdater/wikipedia_updater.py
Outdated
Show resolved
Hide resolved
…dater.py Co-authored-by: Copilot <[email protected]>
…dater.py Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improved error handling for HTTP errors in the
WikipediaUpdaterworkflow. Now, when an HTTP error occurs during document comparison, the error is logged and a corresponding entry is added to the database for better traceability.Error handling improvements:
requests.exceptionsto support handling HTTP errors in the workflow (wikipedia_updater.py).main()function to catchrequests.exceptions.HTTPError, log the error, and create anErrorRetrievalentry in the database with details about the HTTP error (wikipedia_updater.py).