Move data, config and logs to their own folders #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicFrei
reviewed
Nov 15, 2021
| # announcement_coin = load_order('new_listing.json') | ||
| if os.path.isfile('new_listing.json'): | ||
| announcement_coin = load_order('new_listing.json') | ||
| # announcement_coin = load_order(settings.data_folder + '/new_listing.json') |
There was a problem hiding this comment.
Can this commented out block be removed altogether?
DominicFrei
reviewed
Nov 15, 2021
Linus045
requested changes
Dec 28, 2021
| @@ -15,21 +18,21 @@ | |||
| old_coins = ["CHESS","OTHERCRAP"] | |||
|
|
|||
| # loads local configuration | |||
| config = load_config('config.yml') | |||
| config = load_config(settings.config_folder + '/config.yml') | |||
There was a problem hiding this comment.
I think it makes sense to use os.path.join() instead of the + operator.
I will look cleaner and there is no need for slashes at the beginning of the filename
| @@ -0,0 +1,7 @@ | |||
| def init(): | |||
There was a problem hiding this comment.
do we need the init() method here?
All these path variables are constant so simple declaring them should suffice? similar to the globals.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better overview and persistence overview I would propose tho save data, config and logs to their own folders.
Also, if using (docker) containers, this dividing make sense. You can split the configuration from the data you want to persistent.
Input and opinions welcome!