sort task by full table name#56
Merged
Merged
Conversation
cccs-as
approved these changes
May 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes how Ice Keeper schedules maintenance tasks by switching from runtime-based ordering (using historical journal durations) to deterministic alphabetical ordering by each task’s full table name, and adds logging to show the initial task index-to-table mapping before execution.
Changes:
- Added
get_ordered_tasks_by_full_name()to sort tasks alphabetically bytask.task_name()(full table name for maintenance tasks). - Updated CLI commands (
multi,optimize,expire,rewrite_manifests,orphan) to use name-based ordering instead of historical execution-time ordering. - Added
log_initial_task_numbering()to log the ordered task list before scheduling.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ice_keeper/task/task.py | Adds a helper to deterministically sort tasks by full table name (via task_name()). |
| ice_keeper/task/init.py | Re-exports the new ordering helper from the ice_keeper.task package. |
| ice_keeper/ice_keeper.py | Switches CLI scheduling to name-ordering and logs the initial ordered task list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+485
to
+492
| """Log task number to full name mapping before scheduling.""" | ||
| if not tasks: | ||
| logger.info("No tasks to schedule.") | ||
| return | ||
|
|
||
| logger.info("Initial task numbering:") | ||
| for idx, task in enumerate(tasks, start=1): | ||
| logger.info("Task %d -> %s", idx, task.task_name()) |
| ordered_tasks = get_ordered_tasks_by_full_name(tasks) | ||
| log_initial_task_numbering(ordered_tasks) | ||
|
|
||
| executor.submit_tasks_and_wait(ordered_tasks) |
| @@ -6,6 +6,7 @@ | |||
| Task, | |||
| TaskResult, | |||
| get_ordered_tasks_by_execution_time, | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.