Fix/migration config publish issue#2
Closed
CybertronianKelvin wants to merge 8 commits into
Closed
Conversation
The install command used incorrect publish tags (grapesjs-* instead of graper-*) and wrong package identifier, causing vendor:publish to silently fail on fresh installations.
Fixed spatie sub.
CybertronianKelvin
force-pushed
the
fix/migration-config-publish-issue
branch
from
67d75ce to
8510146
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(install): correct vendor:publish tags and provider in GraperInstallCommand
The graper:install command was failing silently on fresh installations
because it used incorrect publish tags and package identifiers.
Changes:
GraperServiceProvider
graper-config/graper-migrations to match the tags generated by
spatie/laravel-package-tools based on the package name
This caused migrations and config files to never be published when
running the installation command.
Fixes #1