Fix panic in FilterModules when processing modules with no Go source files#733
Open
krishardy wants to merge 1 commit into
Open
Fix panic in FilterModules when processing modules with no Go source files#733krishardy wants to merge 1 commit into
krishardy wants to merge 1 commit into
Conversation
…e files: always include the main module (mod.Main == true) without subjecting it to go mod why filtering, which would otherwise exclude it when no packages are imported - Add bounds check in generator.Generate to return an error instead of panicking when the module list is empty - Fix stdlib version redaction in test helper to percent-encode : as %3A when searching within PackageURL (which URL-encodes the version), while keeping literal matching for BOMRef - Expand TestParseModWhy into subtests; add NoDirectDependencies case where all modules are reported as unneeded by go mod why
krishardy
marked this pull request as ready for review
March 10, 2026 03:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #734
Always include the main module (mod.Main == true) without subjecting it to go mod why filtering, which would otherwise exclude it when no packages are imported
Add bounds check in generator.Generate to return an error instead of panicking when the module list is empty
Fix stdlib version redaction in test helper to percent-encode : as %3A when searching within PackageURL (which URL-encodes the version), while keeping literal matching for BOMRef
Expand TestParseModWhy into subtests; add NoDirectDependencies case where all modules are reported as unneeded by go mod why