perf: Optimize SBOM validation by removing itertools.chain - #1033
Open
saquibsaifee wants to merge 1 commit into
Open
perf: Optimize SBOM validation by removing itertools.chain#1033saquibsaifee wants to merge 1 commit into
saquibsaifee wants to merge 1 commit into
Conversation
Contributor
Author
|
During the generation of large SBOMs, validation times were high due to generator evaluation. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Documentation build overview
|
Contributor
Author
|
@jkowalleck can you take a look at this PR to boost SBOM generation turn around |
Signed-off-by: saquibsaifee <saquibsaifee2@gmail.com>
saquibsaifee
force-pushed
the
perf-optimize-bom-validate-17515006840806688594
branch
from
August 31, 2026 16:08
6f5dc72 to
e05bb2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request optimizes the
Bom.validateperformance by replacingitertools.chainand other complex generator expressions with list/set collections and iterations.During the generation of large SBOMs, validation times were high due to generator evaluation.
With this change, the
Bom.validate()running time on an SBOM with 2500 nested components and 2500 services executed 10 times drops from ~49.4 seconds down to ~5.1 seconds. This yields a ~10x execution speedup in terms of validation execution alone.Changes:
mapanditertools.chainfor gathering dependency references and testing root component dependency trees.list.extendrather than dynamically generating generators at runtime.AI Tool Disclosure
Gemini JulesGemini 3.1 ProAffirmation