Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: 9.0.1 #777

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat!: 9.0.1 #777

wants to merge 12 commits into from

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Feb 11, 2025

see milestone: https://github.com/CycloneDX/cyclonedx-python-lib/milestone/8


BREAKING Changes

  • Rename spdx.is_compund_expression -> spdx.is_expression (#779)
  • BomRef affects comparison/hashing (#754 & #780)
    This is only a breaking change if you relied on ordering of elements.
  • Streamline comparison/hashing functions (#755)
    This is only a breaking change if you relied on ordering of elements.
  • Bumped dependency py-serializable >=2 <3, was >=1.1.1 <2 (#775)
    This is only a breaking change if you have other packages depend on that specific version.

as of #754 & #780

as of #779

we have different methods of object comparison here and there, some work
on tuples, other on hashes, other on different structures.

this PR streamlines this.

these changes might cause breaking changes for downstream users.

---------

Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck added enhancement New feature or request breaking change labels Feb 11, 2025
Copy link

codacy-production bot commented Feb 11, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.11% 85.02% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (82e0bb1) 5101 4769 93.49%
Head commit (5630f68) 5187 (+86) 4855 (+86) 93.60% (+0.11%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#777) 267 227 85.02%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jkowalleck jkowalleck added this to the 9.0.0 milestone Feb 11, 2025
jkowalleck and others added 4 commits February 11, 2025 13:29
bump to `py-serializable` v2.0.0:
<https://github.com/madpah/serializable/releases/tag/v2.0.0>
This is considered a breaking change, as downstream users might rely on
the same package's previous version.

Signed-off-by: Jan Kowalleck <[email protected]>
For some this is considered a bug-fix, for others this is a feature - it
is a breaking change anyway since it modifies the order of things.

----

TODO:
- [x] **every** symbol that has a property `bom-ref` MUST utilize it for
dunder methods `hash`,`eq`,`gt`,`lt`,...
- [x] add new test cases from #753
- [x] add new test cases from #540
- [x] add new test cases from #677
- [x] create new tests snapshots (if applicable)

----

> [!important]
> depends on #755

supersedes #678
closes #678

fixes #753
fixes #540
fixes #677

---------

Signed-off-by: wkoot <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Co-authored-by: wkoot <[email protected]>
@jkowalleck jkowalleck marked this pull request as ready for review February 12, 2025 13:05
@jkowalleck jkowalleck requested a review from a team as a code owner February 12, 2025 13:05
@jkowalleck jkowalleck changed the title [WIP] 9.0.0 9.0.0 Feb 12, 2025
@jkowalleck jkowalleck changed the title 9.0.0 feat!: 9.0.0 Feb 12, 2025
semantic-release and others added 6 commits February 12, 2025 13:09
Automatically generated by python-semantic-release

Signed-off-by: semantic-release <[email protected]>
closes #781

Signed-off-by: Jan Kowalleck <[email protected]>
Automatically generated by python-semantic-release

Signed-off-by: semantic-release <[email protected]>
@jkowalleck jkowalleck changed the title feat!: 9.0.0 feat!: 9.0.1 Feb 13, 2025
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck
Copy link
Member Author

planend release is early next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment