Skip to content

Fix annotation serialization issue #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jacobcalvert
Copy link
Contributor

This PR fixes the bom-ref serialization issue in annotations.

Closes #783

@jacobcalvert jacobcalvert requested a review from a team as a code owner April 2, 2025 17:05
@jacobcalvert jacobcalvert force-pushed the jacobcalvert/fix-annotation-serialization-issue branch from e5ee3f3 to 0088429 Compare April 2, 2025 17:07
@Shnatsel
Copy link
Contributor

Shnatsel commented Apr 3, 2025

Ah, good catch! Thank you for the PR!

CI is failing, could you take a look? Perhaps some more tests need to be updated.

@jacobcalvert
Copy link
Contributor Author

Try this one. Sorry, I must have fixed one insta and not the other. This recent commit should fix it up.

@Shnatsel Shnatsel merged commit 100c362 into CycloneDX:main Apr 3, 2025
13 checks passed
@Shnatsel
Copy link
Contributor

Shnatsel commented Apr 3, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotation bom_ref field incorrectly serialized to JSON
2 participants