Make fluent-uri an optional dependency with feature flag#863
Open
woodruffw-bot wants to merge 1 commit intoCycloneDX:mainfrom
Open
Make fluent-uri an optional dependency with feature flag#863woodruffw-bot wants to merge 1 commit intoCycloneDX:mainfrom
woodruffw-bot wants to merge 1 commit intoCycloneDX:mainfrom
Conversation
This allows downstream users to disable the `fluent-uri` feature to remove the dependency when URI validation is not needed. https://claude.ai/code/session_01H51ccpYf6jhtzujzWiypPc Signed-off-by: woodruffw-bot <william+ai@yossarian.net>
woodruffw-bot
force-pushed
the
claude/optional-dependencies-update-BzL5o
branch
from
e02eb2e to
2b8cb98
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello cyclonedx-bom maintainers!
I'm opening this up as part of my work on astral-sh/uv#18761 -- we noticed some dependency shiftage with that PR, which led me to observing that we (as the downstream) don't actually need the fluent-uri dependency at all (it's only used for validation, and we already pre-validate all of our URLs).
Consequently, this makes
fluent-urian optional dep. To avoid breakage I've retained it as a default feature, but this could be changed to make it opt-in in a subsequent release (your call!)Disclosure: the changes in this PR were performed by Claude, through my own orchestration. I've manually reviewed them for correctness/expected behavior.