Skip to content

Log to stderr #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025
Merged

Log to stderr #122

merged 1 commit into from
Apr 21, 2025

Conversation

wlcx
Copy link
Contributor

@wlcx wlcx commented Apr 3, 2025

Make minilogger methods output to outputFile rather than stdout, and set outputFile to stderr.

Resolves #120

@mrutkows
Copy link
Contributor

Hi @wlcx Thanks for your PR. Would you be willing to resubmit and sign your commit (i.e., -s)?

@mrutkows mrutkows self-assigned this Apr 16, 2025
@mrutkows mrutkows added the enhancement New feature or request label Apr 16, 2025
@wlcx
Copy link
Contributor Author

wlcx commented Apr 16, 2025

I don't actually have very active/verified GPG keys personally, can probably sort some if you really need but I'm also happy if you want to review and commit/sign the changes yourself?

@mrutkows
Copy link
Contributor

mrutkows commented Apr 16, 2025

@wlcx

I don't actually have very active/verified GPG keys personally...

You do not need to sign with a GPG key, just set your email address in your git config (global or local) as shown here:
https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#setting-your-email-address-for-every-repository-on-your-computer

and then add -s when you git commit -s -m "message"

Signed-off-by: Sam Willcocks <sam@wlcx.cc>
@wlcx
Copy link
Contributor Author

wlcx commented Apr 17, 2025

Ah, sorry - assumed you meant commit signing. Have amended the commit message

Copy link
Contributor

@mrutkows mrutkows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense; had not tried to use the DumpXXX() methods except for trace/debug output. I may need to allow for an override flag in the future to allow old behavior if for some odd reason someone coded a workflow to stdout.

@mrutkows mrutkows merged commit 10a3b27 into CycloneDX:main Apr 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sbom-utility completion outputs informational messages
2 participants