Clarify TEA Product fields #111
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is an initial schema to define the main TEA objects. It will be further expanded in other PRs that address specific TEA objects. Signed-off-by: Piotr P. Karwasz <[email protected]>
Signed-off-by: Piotr P. Karwasz <[email protected]>
Modifies the documentation of the TEA product and completes its JSON schema. Signed-off-by: Piotr P. Karwasz <[email protected]>
ppkarwasz
force-pushed
the
feat/clarify-product
branch
from
12656b1 to
f33d2bc
Compare
|
I will move the changes to |
madpah
requested changes
Apr 17, 2025
| @@ -39,7 +39,7 @@ The working group has produced a list of use cases and requirements for the prot | |||
|
|
|||
| ## Data model | |||
|
|
|||
| - [TEA Product index](tea-index/tea-index.md): This is the starting point. A "product" is something for sale. The [Transparency Exchange Identifier, TEI](/discovery/readme.md) points to a single product. | |||
| - [TEA Product index](spec/product): This is the starting point. A "product" is something for sale. The [Transparency Exchange Identifier, TEI](/discovery/readme.md) points to a single product. | |||
There was a problem hiding this comment.
Suggested change
| - [TEA Product index](spec/product): This is the starting point. A "product" is something for sale. The [Transparency Exchange Identifier, TEI](/discovery/readme.md) points to a single product. | |
| - [TEA Product index](spec/product.md): This is the starting point. A "product" is something for sale. The [Transparency Exchange Identifier, TEI](/discovery/readme.md) points to a single product. |
There was a problem hiding this comment.
I don't understand why we have JSON schemas separate to the OpenAPI Spec, which can define everything in one place and save repetition @ppkarwasz ?
There was a problem hiding this comment.
See #111 (comment)
I still haven't updated the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the documentation of the TEA product and completes its JSON schema according to what was discussed at the Koala Workshop.