Modifies domain objects after workshop #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR modifies the schema of the domain objects according to the structure discussed in the Koala Workshop Signed-off-by: Piotr P. Karwasz <[email protected]>
ppkarwasz
commented
Apr 17, 2025
Comment on lines
+157
to
+162
| # | ||
| # TEA Component and related objects | ||
| # | ||
| component: | ||
| type: object | ||
| description: A TEA component |
There was a problem hiding this comment.
One of the possibilities discussed in the Workshop was to:
- inline the direct properties of this component (except
versions) intoproduct.components. - have an API endpoint that returns a paginated list of
component_versionobjects.
spec/openapi.yaml
Outdated
Comment on lines
184
to
186
| component_version: | ||
| type: object | ||
| description: A specific version of a TEA leaf |
There was a problem hiding this comment.
A component_version describes a specific binary file that is distributed to consumers. Should we also have a checksum or that file?
Should we have an API endpoint to find the correct component_version based on its checksum?
ppkarwasz
force-pushed
the
feat/domain-objects
branch
from
3e1ddb3 to
edaf583
Compare
…feat/domain-objects Signed-off-by: Piotr P. Karwasz <[email protected]>
Signed-off-by: Piotr P. Karwasz <[email protected]>
ppkarwasz
force-pushed
the
feat/domain-objects
branch
from
0fde141 to
1acf408
Compare
|
This PR is based on #117. |
Signed-off-by: Piotr P. Karwasz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the schema of the domain objects according to the structure discussed in the Koala Workshop