Skip to content

Fix addon wall game test when mods hand out items on login - #10

Merged
rubensworks merged 1 commit into
master-26-ltsfrom
fix/addon-wall-packtests
Oct 10, 2026
Merged

rubensworks merged 1 commit into
master-26-ltsfrom
fix/addon-wall-packtests

Conversation

@rubensworks

Copy link
Copy Markdown
Member

Fixes the last CC2 game test failure in CyclopsMC/packtests#114: testAddonWall fails in the 26.1.2 NeoForge cyclops-all-deps pack.

The test clicks a wall before the chest forms and expects CONSUME. With that pack, the mock player already holds an item when it logs in, most likely the manual Integrated Dynamics hands out on first login. Clicking an unformed wall with an item returns PASS. makeViewer now clears the player's inventory first.

Testing

  • Reproduced locally with that pack's mods in the NeoForge game test server: the test fails with "Expected click result ... Pass", and with the fix all 104 tests pass.
  • ./gradlew build passes. Game tests pass on Forge (104/104) and Fabric (106/106). NeoForge's 104/104 is the run above with the pack loaded.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RSz5r6eowhjNuANBjZE2v6


Generated by Claude Code

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 38078858452

Coverage increased (+0.003%) to 77.296%

Details

  • Coverage increased (+0.003%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 5 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

5 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
org/cyclops/colossalchests2/gametest/GameTestsCommon.java 5 97.02%

Coverage Stats

Coverage Status
Relevant Lines: 6904
Covered Lines: 5652
Line Coverage: 81.87%
Relevant Branches: 2843
Covered Branches: 1882
Branch Coverage: 66.2%
Branches in Coverage %: Yes
Coverage Strength: 9.93 hits per line

💛 - Coveralls

@rubensworks
rubensworks merged commit d895e15 into master-26-lts Oct 10, 2026
2 checks passed
@rubensworks
rubensworks deleted the fix/addon-wall-packtests branch October 10, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants