Repository navigation
Let copper golems use colossal chests - #11
Merged
Merged
Conversation
Golems take items out through the new Golem wall, like from a copper chest, and sort items into the core of any colossal chest without one, so they never put items back where they took them. Loaders have no hook for golem targets, so a mixin extends vanilla's golem behavior, now with a common mixin config for all loaders. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RSz5r6eowhjNuANBjZE2v6
Coverage Report for CI Build 38110247126Coverage decreased (-0.8%) to 76.495%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions29 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
rubensworks
commented
Oct 11, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RSz5r6eowhjNuANBjZE2v6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copper golems can now work with colossal chests:
Implementation
No loader has a hook for golem targets: vanilla only scans
ChestBlockEntitys, and the destination is hard-coded to chests and trapped chests. So a mixin extendsTransportItemsBetweenContainers:The mixin config moved from
loader-forgetoloader-commonand is now also registered for NeoForge and Fabric, withremap = falsesince 26.x is unobfuscated. The golem logic lives inGolemTransport. Non-golem mobs are not affected.Testing
testRecipesalso covers the Golem wall recipe../gradlew buildpasses. Game tests pass twice in a row on NeoForge (108/108), Forge (108/108) and Fabric (110/110).Limitations
🤖 Generated with Claude Code
https://claude.ai/code/session_01RSz5r6eowhjNuANBjZE2v6
Generated by Claude Code