Skip to content

Open Display wall settings on sneak-right-click - #14

Merged
rubensworks merged 1 commit into
master-1.21-ltsfrom
fix/display-sneak-settings
Oct 11, 2026
Merged

rubensworks merged 1 commit into
master-1.21-ltsfrom
fix/display-sneak-settings

Conversation

@rubensworks

Copy link
Copy Markdown
Member

Sneak-right-clicking a Display Chest Wall with an empty hand did nothing, except on a hidden face. The Interface, Redstone and Magnet walls all open their settings on sneak-right-click, so the Display wall now does the same, on any face.

  • Plain right-click is unchanged: it inserts all of the shown item right after an insert, and opens the settings otherwise.
  • The tooltip now ends with "Sneak-right-click with empty hand to configure.", like the other configurable walls.

Testing

  • ./gradlew build passes. Game tests pass on NeoForge (101), Forge (101) and Fabric (103).
  • I removed the game test assertion for the old "sneaking does nothing" behavior. The new behavior opens a menu, and NeoForge doesn't open menus for game test mock players, which is why the other walls' settings tests also create menus directly.
  • NeoForge dev client via clientdevbridge: sneak-right-click opens the Display settings on the front and side faces, and plain right-click still opens them too.
  • On Fabric, opening the Display settings (by any click) disconnects the client until Fix Display wall settings disconnecting Fabric clients #13 is merged.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RSz5r6eowhjNuANBjZE2v6


Generated by Claude Code

Like the other functional walls, sneak-right-clicking a Display wall
with an empty hand now opens its settings, on any face.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RSz5r6eowhjNuANBjZE2v6
@rubensworks
rubensworks merged commit b4ebddc into master-1.21-lts Oct 11, 2026
3 checks passed
@rubensworks
rubensworks deleted the fix/display-sneak-settings branch October 11, 2026 04:39
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 38112181335

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Warning

No base build found for commit 719b589 on master-1.21-lts.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 76.532%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 6892
Covered Lines: 5577
Line Coverage: 80.92%
Relevant Branches: 2849
Covered Branches: 1878
Branch Coverage: 65.92%
Branches in Coverage %: Yes
Coverage Strength: 9.89 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants