Repository navigation
Render chest overlays flush with the chest surface - #15
Merged
Merged
Conversation
Overlays floated a fixed 1/32 block in front of the chest. They now sit a tiny offset in front that grows with camera distance, like vanilla's view offset layering, so they look flush up close and still avoid z-fighting far away. The Display wall's internal layers scale the same way, which also fixes its frame bleeding through the panel at range. The panel sides are dropped, as there is no gap left to cover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RSz5r6eowhjNuANBjZE2v6
Coverage Report for CI Build 38113801969Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.005%) to 76.527%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions30 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlays (the functional wall icons shown while sneaking, the core marker, Display wall panels) floated a fixed 1/32 block in front of the chest, which was visible as a gap from an angle.
Changes
renderSides), since there is no gap left to cover. The public helper stays for addons.RenderChestCore.applyFaceTransformtakes the offset as a parameter;OVERLAY_OFFSETis replaced bygetOverlayOffset.Testing
./gradlew buildandrunGameTestServerpass (NeoForge, Forge, Fabric).🤖 Generated with Claude Code
https://claude.ai/code/session_01RSz5r6eowhjNuANBjZE2v6
Generated by Claude Code