test: coin-support-utils createAccount#436
Open
jhasuraj01 wants to merge 32 commits intodevelopfrom
Open
Conversation
|
jhasuraj01
changed the title
irshadjsr21
requested changes
Apr 30, 2024
Comment on lines
+6
to
+11
| fixtures.valid.forEach(({ name, input, output }) => { | ||
| test(name, () => { | ||
| const result = mapDerivationPath(input); | ||
| expect(result).toStrictEqual(output); | ||
| }); | ||
| }); |
Collaborator
There was a problem hiding this comment.
This needs negative test cases as well
| }); | ||
|
|
||
| test('should create new accounts', done => { | ||
| db.account.getAll.mockResolvedValue([]); |
Collaborator
There was a problem hiding this comment.
We need this test to be configurable. Currently only one test case of this kind can be ran which is hardcoded in __mocks__/createAccountParams
| const observer: Observer<ICreateAccountEvent> = { | ||
| next: value => { | ||
| if (value.type === 'Account') { | ||
| expect(value.account).toBeDefined(); |
Collaborator
There was a problem hiding this comment.
Need to check if we getting the correct result
…dable Co-authored-by: Irshad Ansari <40335357+irshadjsr21@users.noreply.github.com>
Co-authored-by: Irshad Ansari <40335357+irshadjsr21@users.noreply.github.com>
Co-authored-by: Irshad Ansari <40335357+irshadjsr21@users.noreply.github.com>
Co-authored-by: Irshad Ansari <40335357+irshadjsr21@users.noreply.github.com>
Co-authored-by: Irshad Ansari <40335357+irshadjsr21@users.noreply.github.com>
Co-authored-by: Irshad Ansari <40335357+irshadjsr21@users.noreply.github.com>
Co-authored-by: Irshad Ansari <40335357+irshadjsr21@users.noreply.github.com>
Co-authored-by: Irshad Ansari <40335357+irshadjsr21@users.noreply.github.com>
Co-authored-by: Irshad Ansari <40335357+irshadjsr21@users.noreply.github.com>
Co-authored-by: Irshad Ansari <40335357+irshadjsr21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.