Skip to content

Update target frameworks & packages #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Joy-less
Copy link

@Joy-less Joy-less commented Mar 30, 2025

This pull request updates the target frameworks and packages of every project, including one vulnerable dependency and one beta dependency. MemoryPack drops net7.0 and adds net9.0 (as well as the existing netstandard2.1 and net8.0).

@DJGosnell
Copy link

This seems to be a bit of a mass update throughout the code base by changing the targets and then just updating all nuget packages to their latest versions and some linting (Directory slash changes, Variable renaming, etc).

Are there any regressions in any of the packages which were updated?
Why is the Net6VsNet7 project upgraded to net8.0 & net9.0?
Why is the SandboxNet6 project upgraded to .net9?

Don't want to be rude, but the latest PRs you have been issuing lately appear to be less about fixing things in the code and rather increasing the number of commits you have.

Delsin-Yu/GDTask.Nuget#7
Delsin-Yu/GDTask.Nuget#10
neosmart/AsyncLock#23
awaescher/OllamaSharp#210

@Joy-less
Copy link
Author

Joy-less commented Apr 1, 2025

This seems to be a bit of a mass update throughout the code base by changing the targets and then just updating all nuget packages to their latest versions and some linting (Directory slash changes, Variable renaming, etc).

Are there any regressions in any of the packages which were updated?
Why is the Net6VsNet7 project upgraded to net8.0 & net9.0?
Why is the SandboxNet6 project upgraded to .net9?

Don't want to be rude, but the latest PRs you have been issuing lately appear to be less about fixing things in the code and rather increasing the number of commits you have.

Delsin-Yu/GDTask.Nuget#7
Delsin-Yu/GDTask.Nuget#10
neosmart/AsyncLock#23
awaescher/OllamaSharp#210

Hi @DJGosnell.

First of all, I'm not interested in "increasing the number of commits I have", and I don't think anyone cares. Is there a rule against contributing to too many open source projects? All of the listed repositories are being used by my various projects. If you don't want me to make pull requests to this repository, then I won't, that's fine.

The goal of this PR was to upgrade all of the outdated dependencies in MemoryPack. .NET 6/7 are no longer installed by default since they're out-of-support, which was giving me warnings and errors, so I decided to try to bring everything up-to-date. I assumed the .NET 6 vs .NET 7 project was not really being used anymore but if not then I can undo that change.

Please understand that I have the best intentions.
Thank you

@DJGosnell
Copy link

No hard feelings here. I have just been on the wrong side of people trying to contribute for the sake of increasing their own stats. E.g. DigitalOcean Hacktoberfest. This is not my repository, but I use it extensively so I care about it. As long as things are in provided in good-faith, it is always great for the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants