Skip to content

Fix DebounceFrame and ThrottleLastFrame behavior on re-entry #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GallopingDino
Copy link

Previously, if DebounceFrame.OnNext was invoked synchronously during _DebounceFrame.observer.OnNext, the incoming value would be ignored. ThrottleLastFrame had the same problem. Below is a code sample illustrating this issue:

var publisher = new Subject<int>();

publisher.DebounceFrame(1)
    .Subscribe(value =>
    {
        if (value == 1)
        {
            publisher.OnNext(2);
        } else if (value == 2)
        {
            // We'll never get here
        }
    });
    
publisher.OnNext(1);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant