Skip to content

Fix subscribe methods not using latest registered exception handler #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Al12rs
Copy link

@Al12rs Al12rs commented Apr 28, 2025

Previous behaviour

Subscribe and SubscribeAwait were embedding the exception handler at the moment of subscription.
This made it so that if a different handler was registered, the previous one was was still used at the moment of exception.

New behaviour

Embed a lambda that gets the currently registered handler and invokes it at the moment of exception.
This allows long running subscriptions to get their handlers updated correctly if they are changed.

…ods instead of getting the initial one and never checking again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled exceptions inside Subscribe methods don't use newest UnhandledExceptionHandler
1 participant