Skip to content

Fix: Ensures unsubscribing for ToAsyncEnumerable when await-foreach has got out #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aka-nse wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Ensures unsubscribing for ToAsyncEnumerable when await-foreach has got out #362

aka-nse wants to merge 2 commits into from
+54 −2

Conversation

@aka-nse
Copy link

@aka-nse aka-nse commented Nov 21, 2025 •
edited
Loading

This PR fixes #361.

modifications

  • The return object from ObservableExtensions.ToAsyncEnumerable<T> is wrapped, and its iterator calles Dispose of subscription from its DisposeAsync.
  • A new test for ToAsyncEnumerable<T> is added.

breaking change

  • No API signature breaking change is introduced.
  • Now the subscription is reliably unsubscribed when escaping the await-foreach.
    This is likely to be preferable to the previous behavior, but may change side effects in end-user code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sequence from ToAsyncEnumerable is not unsubscribed when break or throw

1 participant

@aka-nse