Skip to content

Commit bd341d3

Browse files
authored
Merge pull request #1 from aknrdureegaesr/release-artifact-handling
Proper artifact handling on release tag building.
2 parents 4c3117d + b996cc2 commit bd341d3

File tree

2 files changed

+18
-36
lines changed

2 files changed

+18
-36
lines changed

.github/workflows/release.yml

Lines changed: 14 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -11,48 +11,26 @@ jobs:
1111
release:
1212
runs-on: ubuntu-latest
1313
needs: build
14+
permissions:
15+
contents: write
1416
if: startsWith(github.ref, 'refs/tags/')
1517
steps:
1618
- name: checkout repo
1719
uses: actions/checkout@v4
1820

19-
- name: Create Release
20-
id: create_release
21-
uses: actions/create-release@v1
22-
env:
23-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
21+
- name: pull artifacts from previous build step
22+
uses: actions/download-artifact@v4
2423
with:
25-
tag_name: ${{ github.ref }}
26-
release_name: Release ${{ github.ref }}
27-
draft: false
28-
prerelease: false
24+
path: release-pdfs
25+
merge-multiple: True
2926

30-
- name: Upload Release Asset slide-N
31-
uses: actions/upload-release-asset@v1
32-
env:
33-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
34-
with:
35-
upload_url: ${{ steps.create_release.outputs.upload_url }}
36-
asset_path: tex/slide-N.pdf
37-
asset_name: slide-N.pdf
38-
asset_content_type: application/pdf
27+
- name: list artifacts
28+
id: ls_release_pdfs
29+
run: ls -l release-pdfs/*.pdf
3930

40-
- name: Upload Release Asset slide-E
41-
uses: actions/upload-release-asset@v1
42-
env:
43-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
44-
with:
45-
upload_url: ${{ steps.create_release.outputs.upload_url }}
46-
asset_path: tex/slide-E.pdf
47-
asset_name: slide-E.pdf
48-
asset_content_type: application/pdf
49-
50-
- name: Upload Release Asset slide-NE
51-
uses: actions/upload-release-asset@v1
52-
env:
53-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
31+
- name: Create Release
32+
id: create_release
33+
uses: softprops/action-gh-release@v2
5434
with:
55-
upload_url: ${{ steps.create_release.outputs.upload_url }}
56-
asset_path: tex/slide-NE.pdf
57-
asset_name: slide-NE.pdf
58-
asset_content_type: application/pdf
35+
files: |
36+
release-pdfs/*.pdf

release-pdfs/.keep

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
This directory is used by the release pipeline.
2+
3+
Not sure it hurts when it doesn't pre-exist.
4+
But it doesn't hurt if it does pre-exist.

0 commit comments

Comments
 (0)