#567: QOIs: refactor to use a decorator #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ppebay
approved these changes
Dec 13, 2024
Contributor
ppebay
left a comment
ppebay
left a comment
There was a problem hiding this comment.
I like your use of the @qoi decorator but as I had to resolve a conflict with the new develop following the merger of PR #568 can you please have a look @lifflander at the resolved merged version of pR #569 ? Tx
lifflander
force-pushed
the
567-improve-qoi-detection
branch
from
3ce4136 to
c95298d
Compare
Contributor
Author
|
Looks good to me, I just rebased it so we don't have a merge commit in there. |
cwschilly
pushed a commit
that referenced
this pull request
May 13, 2025
lifflander
added a commit
that referenced
this pull request
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #567