Skip to content

#584: Add option to run cluster transfer based algorithms without subclustering #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 29, 2025
Merged

#584: Add option to run cluster transfer based algorithms without subclustering #585

merged 5 commits into from
Jan 29, 2025

Conversation

@ppebay
Copy link
Contributor

@ppebay ppebay commented Jan 29, 2025

Resolved #584

@ppebay ppebay self-assigned this Jan 29, 2025
pierrepebay
pierrepebay requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@pierrepebay pierrepebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use the max_subclusters option instead to avoid adding yet another option; we would then have to allow it to be 0 (in which case it would correspond to preserve_subclusters=False)

@ppebay
Copy link
Contributor Author

ppebay commented Jan 29, 2025

Change made @pierrepebay plz review again tx.

@ppebay ppebay merged commit b656fac into develop Jan 29, 2025
10 of 11 checks passed
@ppebay ppebay deleted the 584-add-option-to-run-cluster-transfer-based-algorithms-without-subclustering branch January 29, 2025 15:55
github-actions bot pushed a commit that referenced this pull request Jan 29, 2025
@ppebay
#584: Add option to run cluster transfer based algorithms without sub…
bb2f404 
…clustering (#585)

* #584: added option to preserve subclusters

* #584: fixed CI problem

* #584: addressed PLP review comment

* #584: fixed CI issues

* #584: add max number of subclusters to example to demonstrate its usage
cwschilly pushed a commit that referenced this pull request May 13, 2025
@ppebay @cwschilly
#584: Add option to run cluster transfer based algorithms without sub…
050237f 
…clustering (#585)

* #584: added option to preserve subclusters

* #584: fixed CI problem

* #584: addressed PLP review comment

* #584: fixed CI issues

* #584: add max number of subclusters to example to demonstrate its usage
lifflander pushed a commit that referenced this pull request Jun 2, 2025
@ppebay @lifflander
#584: Add option to run cluster transfer based algorithms without sub…
7a39370 
…clustering (#585)

* #584: added option to preserve subclusters

* #584: fixed CI problem

* #584: addressed PLP review comment

* #584: fixed CI issues

* #584: add max number of subclusters to example to demonstrate its usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrepebay pierrepebay pierrepebay approved these changes

@lifflander lifflander Awaiting requested review from lifflander

Assignees

@ppebay ppebay

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add option to run cluster transfer based algorithms without subclustering

3 participants

@ppebay @pierrepebay