Skip to content

#587: Modify JSON task lister to make it usable even when LBAF is not installed #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2025
Merged

#587: Modify JSON task lister to make it usable even when LBAF is not installed #588

merged 1 commit into from
Feb 7, 2025

Conversation

@ppebay
Copy link
Contributor

@ppebay ppebay commented Feb 7, 2025 •
edited
Loading

Resolves #587

@ppebay ppebay requested a review from pierrepebay February 7, 2025 12:18
@ppebay ppebay self-assigned this Feb 7, 2025
@ppebay ppebay mentioned this pull request Feb 7, 2025
Merged
@ppebay ppebay requested a review from cwschilly February 7, 2025 19:32
cwschilly
cwschilly approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@cwschilly cwschilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just needs a rebase to pass the acceptance test

@cwschilly cwschilly force-pushed the 587-modify-JSON-task-lister-to-make-it-usable-even-when-LBAF-is-not-installed branch from d30b046 to 6b89e0d Compare February 7, 2025 20:20
@ppebay
Copy link
Contributor Author

ppebay commented Feb 7, 2025

Can you please do the rebase @cwschilly ?

@ppebay
Copy link
Contributor Author

ppebay commented Feb 7, 2025

@cwschilly CI error seems to flare up again in this PR, can you please look it? I am going to bail out

@cwschilly
Copy link
Contributor

cwschilly commented Feb 7, 2025

@ppebay Even after a rebase, the test is failing. The failure is unrelated to this PR so I think it's still okay to merge.

Perhaps we should reopen #586 though. I wasn't able to reproduce the test failure on PR #589, but I guess that was just due to the erratic nature of the bug.

@ppebay ppebay merged commit 3203329 into develop Feb 7, 2025
10 of 11 checks passed
@ppebay ppebay deleted the 587-modify-JSON-task-lister-to-make-it-usable-even-when-LBAF-is-not-installed branch February 7, 2025 20:43
cwschilly pushed a commit that referenced this pull request May 13, 2025
@ppebay @cwschilly
#587: modified import (#588)
4ad0268
lifflander pushed a commit that referenced this pull request Jun 2, 2025
@ppebay @lifflander
#587: modified import (#588)
2aec9bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwschilly cwschilly cwschilly approved these changes

@pierrepebay pierrepebay Awaiting requested review from pierrepebay

Assignees

@ppebay ppebay

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modified JSON task lister to make it usable even when LBAF is not installed

3 participants

@ppebay @cwschilly