Skip to content

#609: add latest changes to master #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 3, 2025
Merged

#609: add latest changes to master #610

merged 6 commits into from
Jun 3, 2025

Conversation

@cwschilly
Copy link
Contributor

@cwschilly cwschilly commented Jun 3, 2025 •
edited
Loading

Fixes #609

cwschilly and others added 6 commits June 3, 2025 16:16
@cwschilly
#591: Revamp the JSON file makes to add functionality (#592)
9bfd472 
* #591: initial commit (wip)

* #591: use phase specification classes to generate spec

* #591: change to only write out a single phase

* #591: add other way to assign tasks

* #591: update PhaseSpecification with all params

* #591: fix failing test

* #591: add clarifying comments and clean up
@ppebay @cwschilly
#601: fix actually 2 console log bugs (#602)
c8d971b
@ppebay @cwschilly
#591: Revamp the JSON file maker to add functionality (#593)
32ddfc9 
* #591: renaming and reorganizing to prepare for Python spec

* #591: modified PR to smoothly integrate with PR #592

* #591: fix pylint errors in spec.py

* #591: deleted now unused file

---------

Co-authored-by: Caleb Schilly <[email protected]>
@ppebay @cwschilly
#603: fixed incorrect handling of no sub mode; also fixed incorrect p…
b77e090 
…rintouts (#604)
@ppebay @cwschilly
#605: include all changes made during information stage study (#606)
da6e89a 
* #605: include all changes made during information stage study

* #605: cleaned import as per review
@ppebay @cwschilly
#607: Add homing (delta) term (#608)
576c468 
* #607: added delta everywhere it needs to

* #607: updated documentation for delta

* #607: updated configs

* #607: fixed CI error

* #607: completed implementation of homing cost, tested it, created PR608

* #607: fixed incomplete implementation of some stats when delta is non-0

* #607: fixed undefined variable

* #607: fixed incorrect variable

* #607: added better instrumentation
@cwschilly cwschilly force-pushed the 609-add-latest-changes-to-main branch from 9615e7a to 576c468 Compare June 3, 2025 20:17
@cwschilly cwschilly requested review from lifflander and ppebay June 3, 2025 20:17
ppebay
ppebay approved these changes Jun 3, 2025
View reviewed changes
@lifflander lifflander merged commit 7783498 into master Jun 3, 2025
11 checks passed
@ppebay ppebay deleted the 609-add-latest-changes-to-main branch June 4, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lifflander lifflander lifflander approved these changes

@ppebay ppebay ppebay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cwschilly @lifflander @ppebay