#617: Writing out json is very slow with large files #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I wrote a simple |
cwschilly
commented
Oct 23, 2025
| try: | ||
| self.__extension = parameters["json_output_suffix"] | ||
| self.__compress = parameters["compressed"] | ||
| self.__add_communications = parameters.get("communications", True) |
Contributor
Author
There was a problem hiding this comment.
Does it make sense to default to True here? Or should users opt-in to writing comms?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #617
Explanation: Since writing JSON is a fairly small task, Python multiprocessing was introducing unneeded overhead. It's much faster to just write everything in serial: for the problem in question, the
write()call went from taking 5 minutes down to 4 seconds