#7: Fix iteration breakdown, add frequency analysis, and plot dropped nodes #9
Conversation
|
@nlslatt @lifflander Should we ignore the first iteration during analysis? |
We should probably do one more than the requested number of iterations and completely throw out the first one. I think the first iteration should not be printed or added to the total time. |
|
@cwschilly Are you planning to fix the sensors node name problem as a separate PR or part of this? There are a lot of things that need to be addressed before I can start collecting new data and I'd really like to start collecting it now. |
|
It would be helpful if the list of slowest iterations included the iteration number and not just the time. |
@nlslatt I can put everything in this PR. Going to try to get everything fixed up by the end of the day--I'll ping you when it's ready |
|
@cwschilly Jonathan had asked me for the barrier after the random initialization (i.e., before the for loop within |
|
@cwschilly The node names in the sensors files are still incorrect. All nodes have been given the name of the first node in the allocation. |
cwschilly
changed the title
detection/plot_slow_nodes.py
Outdated
| parser.add_argument('-a', '--analysis', help='Absolute or relative path to the output from detect_slow_nodes', required=True) | ||
| parser.add_argument('-o', '--output', help='Absolute or relative path to the output from detect_slow_nodes', default=None) |
There was a problem hiding this comment.
The help needs to distinguish between the original output (to be used as input) and the new output.
There was a problem hiding this comment.
Is the new output a directory for the plot? That's not clear above.
There was a problem hiding this comment.
Fixed, sorry about that. -o is the path to where you want to save the plot.
Fixes #7
Fixes #8
Also refactors the Python code to be more modular and adds both function timers and a new plot for dropped nodes.
The plot the dropped nodes for previous runs, run from the project dir:
Where: