#25: remove fmt version requirement
#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cz4rs
reviewed
Feb 7, 2025
Contributor
cz4rs
left a comment
cz4rs
left a comment
There was a problem hiding this comment.
Note that DARMA-tasking/vt#2399 allows for using fmt 11.
Overall, maybe we could get away with NOT specifying the version for fmt? That would offer the most flexibility and reduce the maintenance for this package as well ;)
cz4rs
reviewed
Feb 7, 2025
Contributor
Author
Yes agreed. |
cz4rs
force-pushed
the
25-change-fmt-dependency-to-less-than-11
branch
from
f8c8968 to
4e32e27
Compare
cz4rs
changed the title
fmt version requirement
This was referenced Apr 28, 2025
Closed
Co-authored-by: Cezary Skrzyński <[email protected]>
cz4rs
force-pushed
the
25-change-fmt-dependency-to-less-than-11
branch
from
4e32e27 to
b6ae2b7
Compare
cz4rs
force-pushed
the
25-change-fmt-dependency-to-less-than-11
branch
9 times, most recently
from
2a27b70 to
d2d81fc
Compare
cz4rs
force-pushed
the
25-change-fmt-dependency-to-less-than-11
branch
2 times, most recently
from
a3d2ca9 to
bdfe256
Compare
cz4rs
force-pushed
the
25-change-fmt-dependency-to-less-than-11
branch
from
bdfe256 to
8eb588d
Compare
Member
|
Failure happens due to incorrect cmake setup on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25