-
Notifications
You must be signed in to change notification settings - Fork 0
#142: phase: allow starting at non-zero phase #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
cwschilly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may be more efficient to have a single function find both the number of phases n_phases and the minimum phase min_phase and store both as member variables of info. This would reduce the amount of times we have to loop through all ranks and phases.
Getting the number of phases should be a constant time operation of just looking at the size of the |
|
I have made min phase cached so it doesn't compute each time, which should improve performance. |
cwschilly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@lifflander does this need to be re-reviewed? If not @cwschilly please do the update/rebase and send it to @lifflander for merging, thanks |
cabb3c4 to
1b49301
Compare
1b49301 to
03cb853
Compare
Fixes #142