Skip to content

#2454: Add spack-package build to bake file #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 28, 2025
Merged

#2454: Add spack-package build to bake file #2460

merged 7 commits into from
Jul 28, 2025
+56 −16

Conversation

@JacobDomagala
Copy link
Member

@JacobDomagala JacobDomagala commented Jul 21, 2025

Fixes #2454

@JacobDomagala JacobDomagala self-assigned this Jul 21, 2025
@JacobDomagala JacobDomagala linked an issue Jul 21, 2025 that may be closed by this pull request
[CI] fix spack build (Azure) and migrate it to bake (GitHub) #2454
Closed
@github-actions
Copy link

github-actions bot commented Jul 21, 2025

clang-format output for this changeset:

no modified files to format

@JacobDomagala JacobDomagala force-pushed the 2454-ci-fix-spack-build-azure-and-migrate-it-to-bake-github branch from 1802e6a to bf188b2 Compare July 21, 2025 16:27
@JacobDomagala
#2454: Add new ARG (used for testing spack) and use it with bake
9148e12
@JacobDomagala
#2454: Make two groups inside docker-bake.hcl file - one for pull req…
60c5e8a 
…uests and one for develop-only builds. Also new workflow file was added for develop-only bulds
@JacobDomagala JacobDomagala force-pushed the 2454-ci-fix-spack-build-azure-and-migrate-it-to-bake-github branch from bf188b2 to 60c5e8a Compare July 21, 2025 16:28
@JacobDomagala JacobDomagala changed the title #2454: Add new ARG (used for testing spack) and use it with bake #2454: Add spack-package build to bake file Jul 21, 2025
JacobDomagala
JacobDomagala commented Jul 22, 2025
View reviewed changes
@JacobDomagala JacobDomagala force-pushed the 2454-ci-fix-spack-build-azure-and-migrate-it-to-bake-github branch 4 times, most recently from 388df5b to e27d3be Compare July 22, 2025 08:55
@JacobDomagala JacobDomagala force-pushed the 2454-ci-fix-spack-build-azure-and-migrate-it-to-bake-github branch 5 times, most recently from 094c5a2 to e50a89a Compare July 22, 2025 10:29
@JacobDomagala
Copy link
Member Author

JacobDomagala commented Jul 22, 2025

Action result: https://github.com/DARMA-tasking/vt/actions/runs/16441702761/job/46463895273?pr=2460

@JacobDomagala JacobDomagala marked this pull request as ready for review July 22, 2025 11:23
@JacobDomagala JacobDomagala force-pushed the 2454-ci-fix-spack-build-azure-and-migrate-it-to-bake-github branch from e50a89a to 5e2beac Compare July 22, 2025 11:24
cz4rs
cz4rs reviewed Jul 23, 2025
View reviewed changes
cz4rs
cz4rs reviewed Jul 23, 2025
View reviewed changes
cz4rs
cz4rs approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Up for discussion whether we want to run this on PRs too.

docker-bake.hcl Outdated

group "vt-develop" {
targets = [
"vt-build-amd64-ubuntu-20-04-gcc-10-openmpi-cpp-spack",
Copy link
Contributor

@cz4rs cz4rs Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to test spack package only on develop? 🤔
We could probably change spack install darma-vt@develop to use branch. Are there any other limitations / concerns?

Copy link
Member Author

@JacobDomagala JacobDomagala Jul 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand you can only build package with one of the declared versions/branches inside package.py.
In our case it is:

  • 1.0.0
  • 1.5.0
  • develop

https://github.com/DARMA-tasking/spack-package/blob/master/packages/darma-vt/package.py#L59-L61

Copy link
Contributor

@cz4rs cz4rs Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this was probably the reason for setting the build up this way.

Copy link
Member Author

@JacobDomagala JacobDomagala Jul 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we really want to test per branch, we could create a script that modifies the package.py to temporarily include version('branch_name', branch='branch_name')

Copy link
Member Author

@JacobDomagala JacobDomagala Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it seems to be working!

@JacobDomagala JacobDomagala mentioned this pull request Jul 23, 2025
Closed
@JacobDomagala JacobDomagala marked this pull request as draft July 23, 2025 14:33
@JacobDomagala
Copy link
Member Author

JacobDomagala commented Jul 23, 2025

Converting to draft - testing spack-package feature branch

@JacobDomagala JacobDomagala force-pushed the 2454-ci-fix-spack-build-azure-and-migrate-it-to-bake-github branch 2 times, most recently from 426072e to 94857f4 Compare July 23, 2025 14:49
@JacobDomagala
Copy link
Member Author

JacobDomagala commented Jul 23, 2025

@cz4rs @lifflander

Could you review DARMA-tasking/spack-package#32? Once that it merged I'll update this branch to use master branch again.

@JacobDomagala JacobDomagala requested a review from cz4rs July 23, 2025 15:13
@JacobDomagala JacobDomagala force-pushed the 2454-ci-fix-spack-build-azure-and-migrate-it-to-bake-github branch from 94857f4 to 3c94b2f Compare July 28, 2025 14:20
@JacobDomagala JacobDomagala marked this pull request as ready for review July 28, 2025 14:53
@JacobDomagala JacobDomagala force-pushed the 2454-ci-fix-spack-build-azure-and-migrate-it-to-bake-github branch from 3c94b2f to 37af7aa Compare July 28, 2025 14:54
@lifflander lifflander merged commit 497d1c3 into develop Jul 28, 2025
52 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lifflander lifflander lifflander approved these changes

@nmm0 nmm0 Awaiting requested review from nmm0

@cz4rs cz4rs Awaiting requested review from cz4rs

Assignees

@JacobDomagala JacobDomagala

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] fix spack build (Azure) and migrate it to bake (GitHub)

4 participants

@JacobDomagala @lifflander @cz4rs