Skip to content

Conversation

@JacobDomagala
Copy link
Member

@JacobDomagala JacobDomagala commented Jul 22, 2025

Fixes #2461

  1. Fixes code coverage
  1. Uses cache mount for ccache instead of manual copy inside dockerfile

@JacobDomagala JacobDomagala self-assigned this Jul 22, 2025
@JacobDomagala JacobDomagala linked an issue Jul 22, 2025 that may be closed by this pull request
@github-actions
Copy link

clang-format output for this changeset:

no modified files to format

@JacobDomagala
Copy link
Member Author

This should fail now, as we don't have CODECOV_TOKEN secret setup for github actions

@JacobDomagala JacobDomagala force-pushed the 2461-ci-fix-code-coverage-build branch from 34b4417 to ab7f314 Compare July 29, 2025 08:39
@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.18%. Comparing base (7be56f2) to head (fbef7b7).
⚠️ Report is 2020 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2462      +/-   ##
===========================================
- Coverage    85.48%   85.18%   -0.30%     
===========================================
  Files          722      727       +5     
  Lines        25907    31227    +5320     
===========================================
+ Hits         22146    26602    +4456     
- Misses        3761     4625     +864     

see 662 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JacobDomagala JacobDomagala changed the title #2461: Add CODECOV_TOKEN secret to bake and use it #2461: Fix code coverage pipeline Jul 30, 2025
@JacobDomagala JacobDomagala marked this pull request as ready for review July 30, 2025 12:33
@JacobDomagala JacobDomagala force-pushed the 2461-ci-fix-code-coverage-build branch from 30f032b to fbef7b7 Compare July 30, 2025 12:33
Copy link
Collaborator

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lifflander
Copy link
Collaborator

@cz4rs Can you review this also?

dest = "docker-output"
}
]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This helps when building locally too.

Comment on lines +55 to +66
- name: Inject ccache
uses: reproducible-containers/buildkit-cache-dance@v3
with:
builder: ${{ steps.setup-buildx.outputs.name }}
cache-map: |
{
"ccache-archive": {
"target": "/build/ccache",
"id": "${{ matrix.target }}"
}
}
skip-extraction: ${{ steps.ccache-archive.outputs.cache-hit }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
BTW buildkit-cache-dance is a great name for this action 😁

Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lifflander lifflander merged commit db5b884 into develop Jul 30, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] fix code coverage build

4 participants