-
Notifications
You must be signed in to change notification settings - Fork 9
#2461: Fix code coverage pipeline #2462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
no modified files to format
|
|
This should fail now, as we don't have |
34b4417 to
ab7f314
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2462 +/- ##
===========================================
- Coverage 85.48% 85.18% -0.30%
===========================================
Files 722 727 +5
Lines 25907 31227 +5320
===========================================
+ Hits 22146 26602 +4456
- Misses 3761 4625 +864 🚀 New features to boost your workflow:
|
CODECOV_TOKEN secret to bake and use it30f032b to
fbef7b7
Compare
lifflander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
@cz4rs Can you review this also? |
| dest = "docker-output" | ||
| } | ||
| ] | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This helps when building locally too.
| - name: Inject ccache | ||
| uses: reproducible-containers/buildkit-cache-dance@v3 | ||
| with: | ||
| builder: ${{ steps.setup-buildx.outputs.name }} | ||
| cache-map: | | ||
| { | ||
| "ccache-archive": { | ||
| "target": "/build/ccache", | ||
| "id": "${{ matrix.target }}" | ||
| } | ||
| } | ||
| skip-extraction: ${{ steps.ccache-archive.outputs.cache-hit }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
BTW buildkit-cache-dance is a great name for this action 😁
cz4rs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Fixes #2461
ccacheinstead of manual copy inside dockerfile