-
Notifications
You must be signed in to change notification settings - Fork 9
#2482: lib: update bundled libs cmake version requirements to avoid failure with CMake 4.0 #2483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
no modified files to format
|
Pipelines resultsvt-build-amd64-ubuntu-20-04-clang-9-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-22-04-clang-13-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-20-04-gcc-10-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-24-04-clang-17-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-20-04-gcc-9-ldms-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-20-04-gcc-9-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-22-04-gcc-12-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-22-04-clang-15-cpp Build for a87c8cd (2025-10-01 16:47:50 UTC) vt-build-amd64-alpine-3-16-clang-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-22-04-clang-14-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-24-04-clang-16-vtk-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-24-04-clang-16-zoltan-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-24-04-gcc-14-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-22-04-clang-11-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-20-04-gcc-10-openmpi-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-22-04-clang-12-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-24-04-clang-18-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-22-04-gcc-12-vtk-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-24-04-gcc-13-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-20-04-icpx-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-20-04-gcc-9-cuda-12-2-0-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-20-04-gcc-9-cuda-11-4-3-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-22-04-gcc-11-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-20-04-clang-10-cpp Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-20-04-gcc-10-openmpi-cpp-spack Build for 9330467 (2025-11-13 19:40:13 UTC) vt-build-amd64-ubuntu-22-04-clang-15-cpp-cxx20 Build for 9330467 (2025-11-13 19:40:13 UTC) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2483 +/- ##
===========================================
- Coverage 88.52% 88.48% -0.04%
===========================================
Files 728 728
Lines 30909 30910 +1
===========================================
- Hits 27363 27352 -11
- Misses 3546 3558 +12 🚀 New features to boost your workflow:
|
8828c9f to
fcd712f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems alright as a temporary measure, but might cause issues for users with CMake > 4.0. As long as the CI passes, we can have reasonable confidence that no bugs were introduced by touching cmake_minimum_required.
I think we should upgrade the libs in follow-up issues, this should help with everything except for libfort:
- mimalloc 3.18
- EngFormat-Cpp - to activity upstream, but the lib is so small that we should be able to just raise min required version
- brotli 3.15
- json is the one that is using 3.5...4.0 actually, not sure about this one
- libfort - no activity upstream, stuck with 3.0
- yaml-cpp - 3.5...3.30 here with the explicit comment about avoid CMake warnings 🤷
|
@lifflander This is now critical: |
61f212c to
836b38c
Compare
Fixes #2482
This fixes the Mac build which has been consistently failing due to a much later cmake version: