Skip to content

Conversation

@fendykwan
Copy link
Contributor

Found inconsistencies of path strings. Some with leading '/' and some are without leading '/'.
This can cause problems with Uri containing additional paths, such as 404 not found.
Source: StackOverflow

fendykwan and others added 5 commits August 22, 2025 12:50
Adding option to able to append additional path in TypesenseClient
Found inconsistencies of path strings. Some with leading '/' and some are without '/'. This can cause problems with Uri containing additional paths, such as 404 not found.
Source: https://stackoverflow.com/questions/23438416/why-is-httpclient-baseaddress-not-working
@fendykwan
Copy link
Contributor Author

Hi @runeanielsen ,
Would you kindly review this again?
I found some inconsistencies in the httpclient path and I decided to do TrimStart('/') in get, post, patch, and delete methods
I made sure it doesn't broke existing feature with some fiddle tests here: fiddle
Thanks 🙇

@runeanielsen
Copy link
Member

Hi @fendykwan,

I don't know what to think of this yet, I'll think about it and get back to you when I've thought it through.

// Rune

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants