Skip to content

Enh/automatrix_mri2cbct #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
allemangD merged 17 commits into from
May 28, 2025
Merged

Enh/automatrix_mri2cbct #127

allemangD merged 17 commits into from
May 28, 2025

Conversation

@algadm
Copy link
Contributor

@algadm algadm commented May 16, 2025

Hello @allemangD,

This PR introduces several new features, UI improvements, and fixes across the Automatrix and MRI2CBCT modules.

➕ Added functionalities

  • Automatrix
    • Now supports applying transform matrices to .mrk.json landmark files.
    • Output filename generation is more flexible and customizable.
  • MRI2CBCT
    • Added support for bilateral cropping of MRI and CBCT scans.

      Note: Additional bilateral-related logic was implemented but is too detailed to cover fully here.

    • Resampling improvements for MRI:
      • Added left-side padding where appropriate.
      • Fixed centering behavior for better anatomical consistency.

🛠️ Fixes

Added some missing files inside of ImportLibrary.cmake for the MRI2CBCT approximation code to work.

🎨 Other Updates

  • UI improvements in MRI2CBCT for better clarity and scalability as more tools are added.
  • Updated logos for both Automatrix and MRI2CBCT.
  • Revised README to reflect new features and workflow changes.

@algadm algadm marked this pull request as draft May 19, 2025 20:46
@algadm algadm marked this pull request as ready for review May 20, 2025 23:29
allemangD
allemangD approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@allemangD allemangD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified that the Python environment is configured correctly, and CMake package generation succeeds so publication to the Extensions Index should be fine. I did not run the module itself as I don't have suitable hardware at the moment. I'll merge and keep an eye on the dashboard in case it reports errors.

https://slicer.cdash.org/index.php?project=SlicerStable&filtercount=1&showfilters=1&field1=buildname&compare1=63&value1=AutomatedDentalTools

Note the dashboard already reports tests failing. Those same tests fail for me locally, so it doesn't seem this PR is changing anything.

@allemangD allemangD merged commit 8b13ad4 into DCBIA-OrthoLab:main May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allemangD allemangD allemangD approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@algadm @allemangD