Automatically spawn python child process from provider C++ code#21
Open
Automatically spawn python child process from provider C++ code#21
Conversation
rayaq-siddiqui
requested changes
Dec 14, 2024
Member
rayaq-siddiqui
left a comment
rayaq-siddiqui
left a comment
There was a problem hiding this comment.
I think the code looks perfect. I think we should wait until after the current demo to merge this and make the alterations to this code to work for the ML side. I think those will be minor, but just the python dependencies is the only concern.
src/Peers/provider.cpp
Outdated
| std::vector<std::string> args{ | ||
| std::to_string(zmq_sender.getPort()), | ||
| std::to_string(zmq_receiver.getPort())}; | ||
| boost::process::child python_script("/usr/bin/env", "python3", script_path, args); |
Member
There was a problem hiding this comment.
is this dependent on where a user would have their local python installation? for me, when i run where python3, i see that my python installation is in /usr/bin/python3. that won't work with this setup then, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified provider C++ code to use the autogenerated ZMQ sender/receiver ports to spin up the python child process using boost. Every time the provider starts working on a task request, a python child process is created and terminated.