feat: 얼리버드 신청 기능 활성화, 반응형 이미지 도입, 로고 svg로 수정#246
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request activates the early bird signup feature across the landing page, replaces the header logo with an inline SVG, implements responsive image optimization, and removes unused font assets.
Changes:
- Activated early bird modal integration in intro and launch sections
- Replaced text-based logo with inline SVG in header
- Implemented responsive images with sizes attribute across landing sections
- Consolidated keyring images and updated funding section text
Reviewed changes
Copilot reviewed 18 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/shared/components/layout/Header/Header.Desktop.tsx | Replaced landing title text with inline SVG logo |
| src/feature/customerEvent/earlyBirdModal/EarlyBirdModal.tsx | Updated styling to use Tailwind classes |
| src/composite/landing/*/index.tsx | Implemented responsive images using sizes attribute |
| src/composite/landing/intro/components/* | Created reusable early bird event components |
| src/composite/landing/launch/index.tsx | Integrated early bird modal functionality |
| src/composite/landing/fundingDiscount/index.tsx | Consolidated keyring images, updated button text |
| src/app/layout.tsx | Removed unused MoonGetHeavy font |
| src/app/globals.css | Removed landing-title CSS class |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| width={230} | ||
| height={260} | ||
| className="block md:hidden" | ||
| sizes="(max-width: 768px) 230px, 260px" |
There was a problem hiding this comment.
The sizes attribute value appears incorrect. For a media query with max-width: 768px, the format should be "(max-width: 768px) 230px, 391px" matching the widths in the Image component. Currently it shows "230px, 260px" which doesn't correspond to either the mobile (230) or desktop (391) widths.
| sizes="(max-width: 768px) 230px, 260px" | |
| sizes="(max-width: 768px) 230px, 391px" |
| src="/landing/key-rings.png" | ||
| width={500} | ||
| height={400} | ||
| sizes="(max-width: 768px) 300px 200px" |
There was a problem hiding this comment.
The sizes attribute syntax is malformed. It should have proper media query format like "(max-width: 768px) 300px, 500px" instead of "300px 200px" without parentheses or max-width specification.
| sizes="(max-width: 768px) 300px 200px" | |
| sizes="(max-width: 768px) 300px, 500px" |
No description provided.