Skip to content

fix: FI0-10940 add 50-char max validation to Plane containerNumbers#128

Open
salfedev wants to merge 10 commits into
developfrom
bug/FI0-10940-plane-container-50-char-qa-fix
Open

fix: FI0-10940 add 50-char max validation to Plane containerNumbers#128
salfedev wants to merge 10 commits into
developfrom
bug/FI0-10940-plane-container-50-char-qa-fix

Conversation

@salfedev
Copy link
Copy Markdown
Contributor

@salfedev salfedev commented Mar 25, 2026


Description

Please include a summary of the change:

Summary

Adds the missing .max(50) constraint to the containerNumbers array items in the Plane transport validation schemas. This restores the original 50-character limit for the Plane transport type container identification field that was lost when the field was migrated from containerNumber (singular) to containerNumbers (array).

  • planeSchema.ts — added .max(50) + string.max message to array items
  • catchCertificateTransportDetailsSchema.ts — added .max(50) + ccContainerIdentificationNumberMaxLength message to Plane branch items (used by progress service)
  • progress.service.jest.spec.ts — added test: plane with >50-char containerNumbers returns INCOMPLETE

Fixes - Jira Link # FI0-10940

Ticket

FI0-10940

Type of change

Please tick the relevant option for your PR request. Follow Semantic Version: vMAJOR.MINOR.PATCH

  • Bug fix - PATCH (non-breaking change which fixes an issue)
  • New feature - MINOR (non-breaking change which adds functionality)
  • Breaking change - MAJOR (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, or other non-code files.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants