fix: replace indexOf existence checks with includes (SonarCloud maintainability)#138
Open
mnashawati wants to merge 3 commits into
Open
fix: replace indexOf existence checks with includes (SonarCloud maintainability)#138mnashawati wants to merge 3 commits into
mnashawati wants to merge 3 commits into
Conversation
3a3753a to
e0a4b82
Compare
…Site Addresses SonarCloud warning to use Set for existence checks.
e0a4b82 to
9278e2b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Please include a summary of the change:
Replace .indexOf() !== -1 / >= 0 / === -1 patterns with .includes() across 6 source files. This addresses ~9 SonarCloud code smell issues (es6 readability).
.includes() is functionally identical for existence checks and is more readable.
Fixes - Jira Link #
https://eaflood.atlassian.net/browse/FI0-11035
Type of change
Please tick the relevant option for your PR request. Follow Semantic Version: v
MAJOR.MINOR.PATCHChecklist: