Skip to content

fix: replace String#replace() with String#replaceAll() (SonarCloud maintainability)#140

Open
mnashawati wants to merge 2 commits into
developfrom
feature/FI0-11035-sonar-replace-to-replaceall
Open

fix: replace String#replace() with String#replaceAll() (SonarCloud maintainability)#140
mnashawati wants to merge 2 commits into
developfrom
feature/FI0-11035-sonar-replace-to-replaceall

Conversation

@mnashawati
Copy link
Copy Markdown
Contributor

Description

Please include a summary of the change:

  • Replace .replace() with .replaceAll() across 3 source files where the intent is to replace all occurrences. This addresses ~4 SonarCloud code smell issues (es2021 readability).

  • errorExtractor.ts: comma-to-dot path conversion

  • uploads.controller.ts: empty row filtering

  • documentNumber.service.ts: random ID generation

Fixes - Jira Link #
https://eaflood.atlassian.net/browse/FI0-11035

Type of change

Please tick the relevant option for your PR request. Follow Semantic Version: vMAJOR.MINOR.PATCH

  • Bug fix - PATCH (non-breaking change which fixes an issue)
  • New feature - MINOR (non-breaking change which adds functionality)
  • Breaking change - MAJOR (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, or other non-code files.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

…intainability)

Replace .replace() with .replaceAll() across 3 source files where the
intent is to replace all occurrences. This addresses ~4 SonarCloud code
smell issues (es2021 readability).

- errorExtractor.ts: comma-to-dot path conversion
- uploads.controller.ts: empty row filtering
- documentNumber.service.ts: random ID generation
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant