Merged
Conversation
brujeo
reviewed
Dec 29, 2025
app/models/pafs_core/project.rb
Outdated
Comment on lines
160
to
166
| # The presenter's net_carbon_with_blanks_calculated method involves most of the relevant attributes | ||
| # so a change to any one of the relevant values should result in a different hexdigest value. | ||
| # We also include the key years/months as these may also impact carbon calculations. | ||
| # There are extreme edge cases where changes to two attributs offset each other exactly | ||
| # There are extreme edge cases where changes to two attributes offset each other exactly | ||
| # but this is too unlikely to justify the build and maintenance effort of specifying each | ||
| # relevant attribute separately. | ||
| # We also include funding values as these have a bearing on carbon cost calculations. |
Contributor
There was a problem hiding this comment.
This comment is no longer relevant as you're not including net_carbon_with_blanks_calculated value anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change criteria for showing carbon values updated message
https://eaflood.atlassian.net/browse/RUBY-3855