Conversation
https://eaflood.atlassian.net/browse/IWTF-4147 As part of IWTF-4017: GAFL: Dev – RP job provisions new permissions in DynamoDB Done we added a new service to the Sales API that prepares data for renewals. This service will further be enhanced by IWTF-3916: GAFL: Dev – Permissions created by RP job have correct concessions applied Done The new service duplicates a lot of the logic we use for easy renewals in the renewals-write-cache.js processor, so we should be able to replace quite a lot of that with a single call to the Sales API instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-4147
As part of IWTF-4017: GAFL: Dev – RP job provisions new permissions in DynamoDB Done
we added a new service to the Sales API that prepares data for renewals. This service will further be enhanced by IWTF-3916: GAFL: Dev – Permissions created by RP job have correct concessions applied
Done
The new service duplicates a lot of the logic we use for easy renewals in the renewals-write-cache.js processor, so we should be able to replace quite a lot of that with a single call to the Sales API instead.