Skip to content

Feature/sab 212 start page - #22

Closed
ChrisJets432 wants to merge 12 commits into
mainfrom
feature/SAB-212-start-page
Closed

Feature/sab 212 start page#22
ChrisJets432 wants to merge 12 commits into
mainfrom
feature/SAB-212-start-page

Conversation

@ChrisJets432

@ChrisJets432 ChrisJets432 commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator
  • The Start page now has the cards with the correct text
  • Added helpers for the DfE card components (work by @ChrisJets432)
  • Tests added for view components and Start Controller (work by @ChrisJets432)

SAB-303

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

Test Results

0 tests   - 47   0 ✅  - 47   0s ⏱️ -22s
0 suites  -  4   0 💤 ± 0 
0 files    -  4   0 ❌ ± 0 

Results for commit 04819d6. ± Comparison against base commit 207a5c4.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

Summary

Summary
Generated on: 08/20/2026 - 14:36:09
Parser: MultiReport (4x Cobertura)
Assemblies: 4
Classes: 45
Files: 39
Line coverage: 80.4% (363 of 451)
Covered lines: 363
Uncovered lines: 88
Coverable lines: 451
Total lines: 1275
Branch coverage: 70% (98 of 140)
Covered branches: 98
Total branches: 140
Method coverage: Feature is only available for sponsors
Tag: 181_32380997123

Coverage

SchoolAccount.Application - 61.7%
Name Line Branch
SchoolAccount.Application 61.7% 77.2%
SchoolAccount.Application.Abstractions.Behaviours.LoggingDecorator.CommandB
aseHandler
0% 0%
SchoolAccount.Application.Abstractions.Behaviours.LoggingDecorator.CommandB
aseHandler
0%
SchoolAccount.Application.Abstractions.Behaviours.LoggingDecorator.CommandH
andler<TCommand, TResponse>
0% 0%
SchoolAccount.Application.Abstractions.Behaviours.LoggingDecorator.CommandH
andler<TCommand, TResponse>
0%
SchoolAccount.Application.Abstractions.Behaviours.LoggingDecorator.QueryHan
dler<TQuery, TResponse>
70% 50%
SchoolAccount.Application.Abstractions.Behaviours.LoggingDecorator.QueryHan
dler<TQuery, TResponse>
100%
SchoolAccount.Application.DependencyInjection 100% 100%
SchoolAccount.Application.Greetings.GetTimeSpecificHello.GetTimeSpecificHel
loHandler
100% 100%
SchoolAccount.Application.Greetings.GetTimeSpecificHello.GetTimeSpecificHel
loQuery
100%
SchoolAccount.Application.Greetings.GetTimeSpecificHello.GetTimeSpecificHel
loResponse
100%
SchoolAccount.Infrastructure - 100%
Name Line Branch
SchoolAccount.Infrastructure 100% ****
SchoolAccount.Infrastructure.DependencyInjection 100%
SchoolAccount.Infrastructure.Time.DateTimeProvider 100%
SchoolAccount.SharedKernel - 71%
Name Line Branch
SchoolAccount.SharedKernel 71% 37.5%
SchoolAccount.SharedKernel.Error 73.3%
SchoolAccount.SharedKernel.Result 63.6% 50%
SchoolAccount.SharedKernel.Result 90% 50%
SchoolAccount.SharedKernel.ValidationError 0% 0%
SchoolAccount.Web.Mvc - 85.9%
Name Line Branch
SchoolAccount.Web.Mvc 85.9% 73.5%
AspNetCoreGeneratedDocument.Features__ViewStart 100%
AspNetCoreGeneratedDocument.Features_Dashboard_Dashboard 100%
AspNetCoreGeneratedDocument.Features_Error_Error 100% 75%
AspNetCoreGeneratedDocument.Features_Shared__Layout 100% 100%
AspNetCoreGeneratedDocument.Features_Start_Start 100%
Program 95.2% 75%
SchoolAccount.Web.Mvc.Authentication.Extensions.ServiceCollectionExtensions 89% 90%
SchoolAccount.Web.Mvc.Authentication.Handlers.OpenIdConnectEventHandlers 100% 83.3%
SchoolAccount.Web.Mvc.Authentication.UserContext 100% 75%
SchoolAccount.Web.Mvc.DependencyInjection 96.6% 90%
SchoolAccount.Web.Mvc.Extensions.ConfigurationExtensions 0% 0%
SchoolAccount.Web.Mvc.Features.Accounts.AccountController 100% 87.5%
SchoolAccount.Web.Mvc.Features.Dashboard.DashboardController 90% 50%
SchoolAccount.Web.Mvc.Features.Dashboard.DashboardViewModel 100%
SchoolAccount.Web.Mvc.Features.Error.ErrorController 100%
SchoolAccount.Web.Mvc.Features.Error.ErrorViewModel 100% 100%
SchoolAccount.Web.Mvc.Features.Header.HeaderContentProvider 100% 100%
SchoolAccount.Web.Mvc.Features.Start.StartController 100%
SchoolAccount.Web.Mvc.Infrastructure.FeatureConvention 100% 75%
SchoolAccount.Web.Mvc.Infrastructure.FeatureViewLocationExpander 94.1% 70%
SchoolAccount.Web.Mvc.TagHelpers.Components.Card.CardComponent 61.1% 50%
SchoolAccount.Web.Mvc.TagHelpers.Components.Card.CardGenerator 100%
SchoolAccount.Web.Mvc.TagHelpers.Components.Card.CardGridTagHelper 100% 100%
SchoolAccount.Web.Mvc.TagHelpers.Components.Card.CardImage 100%
SchoolAccount.Web.Mvc.TagHelpers.Components.Card.CardImageTagHelper 100%
SchoolAccount.Web.Mvc.TagHelpers.Components.Card.CardMeta 0%
SchoolAccount.Web.Mvc.TagHelpers.Components.Card.CardMetaTagHelper 0%
SchoolAccount.Web.Mvc.TagHelpers.Components.Card.CardOptions 100%
SchoolAccount.Web.Mvc.TagHelpers.Components.Card.CardTagHelper 86.3% 50%

# Conflicts:
#	src/SchoolAccount.Web.Mvc/Features/Start/StartController.cs
#	tests/SchoolAccount.IntegrationTests/Features/CrossCutting/AnonymousEndpointGuardrailTests.cs
# Conflicts:
#	src/SchoolAccount.Web.Mvc/DependencyInjection.cs
@SimonR-Education
SimonR-Education marked this pull request as ready for review August 20, 2026 15:07
@@ -0,0 +1,82 @@
using Microsoft.AspNetCore.Mvc.Rendering;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure tags is the right approach vs a partial. We need to discuss how we go about these things before proceeding with the work

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With previous conversions about introducing a DFE version of the govukaspnetcore repo I thought if that's the aim instead of repeating work this could be introduction where we could then just lift and shift with minimal effort.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough @ChrisJets432, I can see the logic if a DfE version of govuk-aspnetcore is definitely happening. My concern is that it isn't a decision yet, it's something we've talked about a couple of times. Building this PR around a target that doesn't exist means we take on the cost now for a payoff that might not land. I know it seems small but these things quickly balloon if left unchecked.

There's also a tag helper vs partial tradeoff on its own terms that I don't think we've properly weighed that up and a quick convo before starting would allow us to iron out the direction and that's something I want to encourage we do early before the work starts in earnest. I think here we should try and utilise the output from the design team, lift the html / scss they've created into a small partial.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay @paulcustance-al, the way previous conversations have happened I thought it was a done deal - we've even had countless conversations about giving to the community.

If partials are the preferred option, drop the tag helpers and I'll stash that work once I'm back as a just in case we use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants