Feature/sab 212 start page - #22
Conversation
…ts and govuk-frontend npm import for sass mixins etc
SummarySummary
CoverageSchoolAccount.Application - 61.7%
SchoolAccount.Infrastructure - 100%
SchoolAccount.SharedKernel - 71%
SchoolAccount.Web.Mvc - 85.9%
|
# Conflicts: # src/SchoolAccount.Web.Mvc/Features/Start/StartController.cs # tests/SchoolAccount.IntegrationTests/Features/CrossCutting/AnonymousEndpointGuardrailTests.cs
…ith updated styling
# Conflicts: # src/SchoolAccount.Web.Mvc/DependencyInjection.cs
| @@ -0,0 +1,82 @@ | |||
| using Microsoft.AspNetCore.Mvc.Rendering; | |||
There was a problem hiding this comment.
I'm not sure tags is the right approach vs a partial. We need to discuss how we go about these things before proceeding with the work
There was a problem hiding this comment.
With previous conversions about introducing a DFE version of the govukaspnetcore repo I thought if that's the aim instead of repeating work this could be introduction where we could then just lift and shift with minimal effort.
There was a problem hiding this comment.
Fair enough @ChrisJets432, I can see the logic if a DfE version of govuk-aspnetcore is definitely happening. My concern is that it isn't a decision yet, it's something we've talked about a couple of times. Building this PR around a target that doesn't exist means we take on the cost now for a payoff that might not land. I know it seems small but these things quickly balloon if left unchecked.
There's also a tag helper vs partial tradeoff on its own terms that I don't think we've properly weighed that up and a quick convo before starting would allow us to iron out the direction and that's something I want to encourage we do early before the work starts in earnest. I think here we should try and utilise the output from the design team, lift the html / scss they've created into a small partial.
There was a problem hiding this comment.
Okay @paulcustance-al, the way previous conversations have happened I thought it was a done deal - we've even had countless conversations about giving to the community.
If partials are the preferred option, drop the tag helpers and I'll stash that work once I'm back as a just in case we use them.
SAB-303